Adding full details on what are the requirements for the SPI#4162
Open
Adding full details on what are the requirements for the SPI#4162
Conversation
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
vietj
reviewed
Nov 9, 2021
| */ | ||
| public String encode() { | ||
| return Json.CODEC.toString(this, false); | ||
| return Json.CODEC.toString(this.list, false); |
Member
There was a problem hiding this comment.
this seems to be more than a detail, is it a bug ?
Contributor
Author
There was a problem hiding this comment.
As I was debugging to figure out the behavior I noticed that we can reduce jackson work, as it internally doesn't need to do a 1st lookup on the registered classes for see that JsonArray needs some extra processing. Which is unwrapping the list.
So the behavior didn't change, the stacktraces are just shorter because we help jackson.
Contributor
Author
There was a problem hiding this comment.
Same applies to JsonObject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paulo Lopes pmlopes@gmail.com
Motivation:
Users trying to implement a custom JsonCodec face application failures because the expectations of the SPI are not well documented. For example, nothing is stated over how to encode
JsonObject/JsonArrayor the RFCs vert.x implements.This PR is mostly a documentation update explaining the expectations so users can write working codecs.